williaster commented on a change in pull request #4893: add sticky to sidepane
URL:
https://github.com/apache/incubator-superset/pull/4893#discussion_r186224107
##########
File path: superset/assets/src/dashboard/components/BuilderComponentPane.jsx
##########
@@ -1,68 +1,81 @@
import React from 'react';
import cx from 'classnames';
+import { StickyContainer, Sticky } from 'react-sticky';
import NewColumn from './gridComponents/new/NewColumn';
import NewDivider from './gridComponents/new/NewDivider';
import NewHeader from './gridComponents/new/NewHeader';
import NewRow from './gridComponents/new/NewRow';
import NewTabs from './gridComponents/new/NewTabs';
-import SliceAdderContainer from '../containers/SliceAdder';
+import SliceAdder from '../containers/SliceAdder';
+import { t } from '../../locales';
class BuilderComponentPane extends React.PureComponent {
constructor(props) {
super(props);
this.state = {
- showSlices: false,
+ slideDirection: '',
};
- this.openSlicesPane = this.showSlices.bind(this, true);
- this.closeSlicesPane = this.showSlices.bind(this, false);
+ this.openSlicesPane = this.slide.bind(this, 'slide-in');
Review comment:
it'd be better to make these `const`s
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
