williaster commented on a change in pull request #5524: A tagging system for
dashboards, charts and queries
URL:
https://github.com/apache/incubator-superset/pull/5524#discussion_r207974257
##########
File path: superset/assets/package.json
##########
@@ -80,6 +80,7 @@
"mustache": "^2.2.1",
"nvd3": "1.8.6",
"parse-iso-duration": "^1.0.0",
+ "promise-polyfill": "8.0.0",
Review comment:
do you need this? `babel-polyfill` should already include this. also, it's
not a dependency it's a dev dependency because the code is transpiled before
being sent to the browser
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
