williaster commented on a change in pull request #5524: A tagging system for
dashboards, charts and queries
URL:
https://github.com/apache/incubator-superset/pull/5524#discussion_r207978727
##########
File path: superset/assets/src/welcome/App.jsx
##########
@@ -35,16 +78,16 @@ export default class App extends React.PureComponent {
bsSize="sm"
style={{ marginTop: '25px' }}
placeholder="Search"
- value={this.state.search}
- onChange={this.onSearchChange}
+ value={this.state.dashboardSearch}
+ onChange={this.onDashboardSearchChange}
/>
</Col>
</Row>
<hr />
- <DashboardTable search={this.state.search} />
+ <DashboardTable search={this.state.dashboardSearch} />
</Panel>
</Tab>
- <Tab eventKey={2} title={t('Recently Viewed')}>
+ <Tab eventKey={'recent'} title={t('Recently Viewed')}>
Review comment:
no need for `{}` since it's a string
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
