williaster commented on a change in pull request #5524: A tagging system for
dashboards, charts and queries
URL:
https://github.com/apache/incubator-superset/pull/5524#discussion_r208065934
##########
File path: superset/assets/package.json
##########
@@ -121,7 +123,9 @@
"supercluster":
"https://github.com/georgeke/supercluster/tarball/ac3492737e7ce98e07af679623aad452373bbc40";,
"underscore": "^1.8.3",
"urijs": "^1.18.10",
- "viewport-mercator-project": "^5.0.0"
+ "url-polyfill": "^1.0.13",
Review comment:
`react-router` handles mapping url state to specific components/props. it
may be overkill for this, but it does literally everything you're trying to do
with respect to `url <> react state` syncing and we should use it long-term.
say you don't use react router, why do you need the `url-polyfill`? we
already have [instances of `new
URL(...)`](https://github.com/apache/incubator-superset/blob/c06531950869d84a50e7914b945ba6ceb2a5c179/superset/assets/src/explore/exploreUtils.js#L60)
in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
