kristw commented on a change in pull request #5893: [SIP-6] Add reactify
function and convert world map to new directory structure.
URL:
https://github.com/apache/incubator-superset/pull/5893#discussion_r218259279
##########
File path: superset/assets/src/visualizations/WorldMap/transformProps.js
##########
@@ -0,0 +1,11 @@
+export default function transformProps(basicChartInput) {
Review comment:
It could be part of the `BasicChartInput` or extended class.
For example, `class PieChartInput extends BasicChartInput` then in the
constructor you parse `formData` with `new PieChartFormData(formData)`.
Maybe we should use TypeScript after all lol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
