kristw commented on a change in pull request #5893: [SIP-6] Add reactify
function and convert world map to new directory structure.
URL:
https://github.com/apache/incubator-superset/pull/5893#discussion_r218565237
##########
File path: superset/assets/src/visualizations/models/BasicChartInput.js
##########
@@ -0,0 +1,13 @@
+import convertKeysToCamelCase from '../../utils/convertKeysToCamelCase';
+
+export default class BasicChartInput {
+ constructor(slice, payload, setControlValue) {
+ this.width = slice.width();
Review comment:
Doesn't work with the explore page yet due to the parent `<div>` from
bootstrap panel does not know its height so when `ParentSize` tries to get
height 100%, it ends up getting the entire screen height. I don't feel like
changing the explore page div style in this PR, so I will pass the `width` and
`height` from `slice` as separated argument from `basicChartInput` instead and
remove this once I work on the `Chart.jsx`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
