kristw commented on a change in pull request #5893: [SIP-6] Add reactify function and convert world map to new directory structure. URL: https://github.com/apache/incubator-superset/pull/5893#discussion_r218256530
########## File path: superset/assets/src/visualizations/WorldMap/ReactWorldMap.js ########## @@ -0,0 +1,4 @@ +import reactify from '../../utils/reactify'; +import WorldMap from './WorldMap'; + +export default reactify(WorldMap); Review comment: I am afraid I will make mistake when importing. If I specify `./WorldMap`, which one will webpack resolve to first? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
