williaster commented on a change in pull request #5875: [SIP-4] replace chart
ajax calls with `SupersetClient`
URL:
https://github.com/apache/incubator-superset/pull/5875#discussion_r218670796
##########
File path: superset/assets/cypress/utils/readResponseBlob.js
##########
@@ -0,0 +1,11 @@
+// This function returns a promise that resolves to the value
+// of the passed response blob. It assumes the blob should be read as text,
+// and that the response can be parsed as JSON. This is needed to read
+// the value of any fetch-based response.
+export default function readResponseBlob(blob) {
Review comment:
@michellethomas thanks for bringing this up, it looks okay from the cypress
UI
<img
src="https://user-images.githubusercontent.com/4496521/45732244-3ee9e200-bb90-11e8-898d-eaad40d90ba3.png";
width="200" />
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/4496521/45732244-3ee9e200-bb90-11e8-898d-eaad40d90ba3.png"](https://user-images.githubusercontent.com/4496521/45732244-3ee9e200-bb90-11e8-898d-eaad40d90ba3.png"){kind=link}