williaster commented on a change in pull request #5875: [SIP-4] replace chart
ajax calls with `SupersetClient`
URL:
https://github.com/apache/incubator-superset/pull/5875#discussion_r220704347
##########
File path: superset/assets/src/common.js
##########
@@ -38,9 +39,15 @@ getInstance()
.setDefaultSchemeName('bnbColors');
export function appSetup() {
- // A set of hacks to allow apps to run within a FAB template
+ // A set of hacks to allow apps to run within a FAB template
// this allows for the server side generated menus to function
window.$ = $;
window.jQuery = $;
require('bootstrap');
+
+ SupersetClient.configure({ host: (window.location && window.location.host)
|| '' })
Review comment:
noting from testing in staging that we must also configure `protocol` here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
