williaster commented on a change in pull request #5875: [SIP-4] replace chart
ajax calls with `SupersetClient`
URL:
https://github.com/apache/incubator-superset/pull/5875#discussion_r220704200
##########
File path: superset/assets/src/chart/chartAction.js
##########
@@ -1,16 +1,16 @@
-import URI from 'urijs';
-
+/* global window, AbortController */
+/* eslint no-undef: 'error' */
+import { SupersetClient } from '@superset-ui/core';
import { getExploreUrlAndPayload, getAnnotationJsonUrl } from
'../explore/exploreUtils';
import { requiresQuery, ANNOTATION_SOURCE_TYPES } from
'../modules/AnnotationTypes';
+import { addDangerToast } from '../messageToasts/actions';
import { Logger, LOG_ACTIONS_LOAD_CHART } from '../logger';
import { COMMON_ERR_MESSAGES } from '../utils/common';
import { t } from '../locales';
-const $ = (window.$ = require('jquery'));
-
export const CHART_UPDATE_STARTED = 'CHART_UPDATE_STARTED';
-export function chartUpdateStarted(queryRequest, latestQueryFormData, key) {
- return { type: CHART_UPDATE_STARTED, queryRequest, latestQueryFormData, key
};
+export function chartUpdateStarted(queryController, latestQueryFormData, key) {
Review comment:
noting that the abort controller doesn't seem to be passed along in the
reducer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
