graceguo-supercat commented on a change in pull request #6013: [Sqllab] Add
offline state to sqllab
URL:
https://github.com/apache/incubator-superset/pull/6013#discussion_r224558407
##########
File path: superset/assets/src/SqlLab/components/SqlEditorLeftBar.jsx
##########
@@ -262,7 +267,14 @@ class SqlEditorLeftBar extends React.PureComponent {
);
}
}
+
+function mapStateToProps({ sqlLab }) {
+ return {
+ offline: sqlLab.offline,
+ };
+}
+
SqlEditorLeftBar.propTypes = propTypes;
SqlEditorLeftBar.defaultProps = defaultProps;
-export default SqlEditorLeftBar;
+export default connect(mapStateToProps)(SqlEditorLeftBar);
Review comment:
is adding redux connect for this component necessary? where do you need to
check state?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
