graceguo-supercat commented on a change in pull request #6013: [Sqllab] Add
offline state to sqllab
URL:
https://github.com/apache/incubator-superset/pull/6013#discussion_r224671662
##########
File path: superset/assets/src/SqlLab/components/SouthPane.jsx
##########
@@ -39,6 +42,12 @@ class SouthPane extends React.PureComponent {
latestQuery = props.editorQueries[props.editorQueries.length - 1];
Review comment:
if it is in offline state, you don't need to run these logic, you just
render offline and exit early, right? so you can move offline check before this
line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
