graceguo-supercat commented on a change in pull request #6013: [Sqllab] Add
offline state to sqllab
URL:
https://github.com/apache/incubator-superset/pull/6013#discussion_r224672052
##########
File path: superset/assets/src/SqlLab/components/SouthPane.jsx
##########
@@ -39,6 +42,12 @@ class SouthPane extends React.PureComponent {
latestQuery = props.editorQueries[props.editorQueries.length - 1];
}
let results;
+ if (this.props.offline){
+ return (
+ <Label className="m-r-3" bsStyle={STATE_BSSTYLE_MAP['offline']}>
+ offline
Review comment:
instead of create a hard-coded text here, you should create new entry in
STATUS_OPTIONS in constants.js
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
