betodealmeida commented on a change in pull request #14680:
URL: https://github.com/apache/superset/pull/14680#discussion_r633928405
##########
File path: tests/databases/api_tests.py
##########
@@ -1454,3 +1454,25 @@ def test_validate_parameters_invalid_host(self,
is_hostname_valid):
},
]
}
+
+ def test_validate_parameters_with_mysql(self):
Review comment:
I don't understand this test. If we're passing the correct parameters
why do we expect the status code to be 422?
You probably only need to update this test (which should fail otherwise with
your PR):
https://github.com/apache/superset/pull/14208/files#diff-b8428a369bdee6a99d7d4da28161a32d50477174192f9fade2040a335a4f2e42R1254
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -53,7 +53,7 @@
CONNECTION_UNKNOWN_DATABASE_REGEX = re.compile("Unknown database
'(?P<database>.*?)'")
-class MySQLEngineSpec(BaseEngineSpec):
+class MySQLBaseEngineSpec(BaseEngineSpec):
Review comment:
There's no need to split the class into two. Just add the mixin and
attributes here.
(Postgres was already split into two, probably because of Redshift.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
