betodealmeida commented on a change in pull request #14680:
URL: https://github.com/apache/superset/pull/14680#discussion_r634033771
##########
File path: superset/db_engine_specs/mysql.py
##########
@@ -53,11 +53,16 @@
CONNECTION_UNKNOWN_DATABASE_REGEX = re.compile("Unknown database
'(?P<database>.*?)'")
-class MySQLEngineSpec(BaseEngineSpec):
+class MySQLEngineSpec(BaseEngineSpec, BasicParametersMixin):
engine = "mysql"
engine_name = "MySQL"
max_column_name_length = 64
+ drivername = "mysql"
Review comment:
I just realized we should be specific here:
```suggestion
drivername = "mysql+mysqldb"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
