betodealmeida commented on a change in pull request #14680:
URL: https://github.com/apache/superset/pull/14680#discussion_r635370404
##########
File path: tests/databases/api_tests.py
##########
@@ -1427,7 +1427,73 @@ def test_available(self, app,
get_available_engine_specs):
"preferred": True,
"sqlalchemy_uri_placeholder":
"postgresql+psycopg2://user:password@host:port/dbname[?key=value&key=value...]",
},
- {"engine": "mysql", "name": "MySQL", "preferred": False},
+ {"engine": "hana", "name": "SAP HANA", "preferred": False},
+ ]
+ }
+
+ @mock.patch("superset.databases.api.get_available_engine_specs")
+ @mock.patch("superset.databases.api.app")
+ def test_available_with_mysql(self, app, get_available_engine_specs):
Review comment:
You could've combined this and the test above in a single one:
```
get_available_engine_specs.return_value = [
PostgresEngineSpec,
MySQLEngineSpec,
HanaEngineSpec,
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
