geido commented on a change in pull request #14823:
URL: https://github.com/apache/superset/pull/14823#discussion_r639737216
##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -322,3 +322,7 @@ export const CardStyles = styled.div`
text-decoration: none;
}
`;
+
+export const HOMEPAGE_CHART_FILTER = 'homepage_chart_filter';
Review comment:
The utils file looks like a weird place to me to put these constants
##########
File path: superset-frontend/src/views/CRUD/welcome/ActivityTable.tsx
##########
@@ -188,7 +193,7 @@ export default function ActivityTable({
label: t('Edited'),
onClick: () => {
setActiveChild('Edited');
- setInLocalStorage('activity', { activity: 'Edited' });
+ setInLocalStorage(HOMEPAGE_ACTIVITY_FILTER, { activity: 'Edited' });
Review comment:
It would be great if we could have an Enum also for the activity types,
such as Edited, Created, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
