nytai commented on a change in pull request #14823:
URL: https://github.com/apache/superset/pull/14823#discussion_r640194777
##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -322,3 +322,7 @@ export const CardStyles = styled.div`
text-decoration: none;
}
`;
+
+export const HOMEPAGE_CHART_FILTER = 'homepage_chart_filter';
Review comment:
Can we add a comment describing what these constants are and how they're
sued. Or perhaps move them to a file/module called `storage-keys` or something
descriptive. I guess there's already the `localStorageHelpers` module, perhaps
it would make sense to store these constants there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
