nytai commented on a change in pull request #14823:
URL: https://github.com/apache/superset/pull/14823#discussion_r640195497
##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -322,3 +322,7 @@ export const CardStyles = styled.div`
text-decoration: none;
}
`;
+
+export const HOMEPAGE_CHART_FILTER = 'homepage_chart_filter';
Review comment:
There seems to be quite a few instances of
`getFromLocalStorage`/`setInLocalStorage` throughout the codebase. Each one is
using a different approach for managing keys (userId, enum, and now constants).
It would be good to have a unified approach around this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
