villebro opened a new pull request #14896: URL: https://github.com/apache/superset/pull/14896
### SUMMARY Harmonize AntD Select components that are used in Explore/Dashboard view. This changes the following: - Changes AdHoc Filter Select to show the `StopOutline` Icon if "NOT IN" operator is selected. This is to align the behavior with the native select filter polish introduced in #14873 - Show "Create: <value>" instead of "<value>" when given the option to create a select option that doesn't exist in the dataset. This is to mimic the behavior of the `react-select` based component used in Filter Box:  ### BEFORE When "NOT IN" is selected in the adhoc filter popover, we currently use the default `CheckOutlined` icon:  When being presented with the option to create a value that doesn't exist in the dataset, the option to use a value that doesn't exist is shown as-is:  ### AFTER When "NOT IN" is selected in the adhoc filter popover, we now use the `StopOutlined`  When being presented with the option to create a value that doesn't exist in the dataset, The creatable value is prefixed with "Create" and the value placed inside quotes:  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
