simcha90 commented on a change in pull request #14896:
URL: https://github.com/apache/superset/pull/14896#discussion_r642233349
##########
File path:
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
##########
@@ -265,7 +265,11 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
loading={isRefreshing}
maxTagCount={5}
menuItemSelectedIcon={
- inverseSelection ? <StopOutlined /> : <CheckOutlined />
+ inverseSelection ? (
+ <Icons.StopOutlined iconSize="m" />
+ ) : (
+ <Icons.CheckOutlined iconSize="m" />
+ )
Review comment:
May be shorter will be and also without duplication :)
```
const Icon = inverseSelection ? Icons.StopOutlined : Icons.CheckOutlined
...
menuItemSelectedIcon={<Icon iconSize="m" />}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
