michael-s-molina commented on a change in pull request #14896:
URL: https://github.com/apache/superset/pull/14896#discussion_r641592198
##########
File path:
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.jsx
##########
@@ -417,6 +418,9 @@ export default class AdhocFilterEditPopoverSimpleTabContent
extends React.Compon
onSearch={val => this.setState({ currentSuggestionSearch: val })}
onSelect={this.clearSuggestionSearch}
onBlur={this.clearSuggestionSearch}
+ menuItemSelectedIcon={
+ operator === 'NOT IN' ? <StopOutlined /> : <CheckOutlined />
Review comment:
`<Icons.StopOutlined>` and `<Icons.CheckOutlined>`
##########
File path:
superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterEditPopoverSimpleTabContent/index.jsx
##########
@@ -39,6 +39,7 @@ import AdhocFilter, {
CLAUSES,
} from 'src/explore/components/controls/FilterControl/AdhocFilter';
import columnType from
'src/explore/components/controls/FilterControl/columnType';
+import { CheckOutlined, StopOutlined } from '@ant-design/icons';
Review comment:
Here we should use the `src/components/Icons`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
