sowo commented on a change in pull request #15082:
URL: https://github.com/apache/superset/pull/15082#discussion_r657338240
##########
File path: superset/models/core.py
##########
@@ -379,6 +379,9 @@ def _log_query(sql: str) -> None:
with closing(engine.raw_connection()) as conn:
cursor = conn.cursor()
+ if hasattr(cursor, 'fetch_size'):
Review comment:
According to the elasticsearch-dbapi docs
(https://github.com/preset-io/elasticsearch-dbapi#fetch-size), the fetch_size
is set at the cursor level and not when initiating a connection. As far as I
understand the code (see
https://github.com/apache/superset/blob/a330b664c13e34a4c7ca954f9a3a527a43a5535f/superset/models/core.py#L404),
there's no method that I could override to create a cursor with engine
specific settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
