dpgaspar commented on a change in pull request #15082:
URL: https://github.com/apache/superset/pull/15082#discussion_r656889274
##########
File path: superset/models/core.py
##########
@@ -379,6 +379,9 @@ def _log_query(sql: str) -> None:
with closing(engine.raw_connection()) as conn:
cursor = conn.cursor()
+ if hasattr(cursor, 'fetch_size'):
Review comment:
wouldn't it make more sense to just set your database connection to
whatever top value you need?
I mean why not just configure the elasticsearch connection with the
fetch_size for ROW_LIMIT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
