EBoisseauSierra commented on pull request #15303: URL: https://github.com/apache/superset/pull/15303#issuecomment-875470864
Thank you for your brilliant work, it looks amazing! :rocket: Here are a some very minor details I've picked along the way: **Empty selection by default** When creating a new graph, the first chart type (here, Table) is selected by default (cf. lower half of the dialog). It would feel more natural (to me) that no chart is selected by default.  **Selection not cleared when changing category** In the same spirit, I'd like to be able to “clear” the selected visualization when changing category. Currently, the last selection “sticks” in the lower half of the dialog, even if that chart type isn't part of the currently selected Category (upper half). This can cause some confusion as I can have both “BigNumber” (selected chart type) and “Correlation” (selected category) at the same time…  **Charts categorization** I fully understand this is not a trivial task and that no solution might satisfy everyone. Here are just some of the chart categorisation that appeared unnatural to me: * _Move deck.gl to Map:_ deck.gl charts are currently in Others. This seems intentional, yet it would feel more natural to me to find them in the Map category. * _Move funnel to Flow:_ The funnel chart is currently listed in KPI, yet I understand that KPI charts should be more one single value, rather than the evolution of one value over a process/some given steps. In absolute terms “Evolution” would be a natural category as well, yet I understand that Funnel would contrast with the more TS-related chart that are currently in this category. * _Horizon to Evolution?:_ Horizon is a tricky one, but because its abscissa is time, I'd put it in “Evolution”. * _Ranking:_ * I see why WordCloud is there, but if I were to look for it, I wouldn't think it could be in the Ranking category (rather “Other”). * Nightingale would, for me, better fit in “Part of a whole” (if I understand that chart correctly) — or distribution. I appreciate the ranking is coherent with D3's one (and I even voted in favour of that ranking in SIP-67)… but the categorization still feels a bit unnatural to me (i.e. if I were to look for a given chart, I'm not sure I would find it first time/I wouldn't struggle finding it — btw, the search bar is a must have, thanks!). **Browse through all charts at a glance** I am aware this defeats a large part of your work with the categorization, but something I like with [D3's gallery](https://www.d3-graph-gallery.com/) is that I can have all chart types at a glance by scrolling through one single page. Here, when one clicks on a category, it filters out all the other charts. Perhaps a presentation similar to [Echarts gallery](https://echarts.apache.org/examples/en/index.html) — where all charts are in one page, with categories as section headings and the list of categories on the left column allowing to “jump” to the right anchor (yet without “filtering out” any chart) — could help? **Add “deprecated” label** Some charts are due to be deprecated. This is detailed in their description, yet I feel this doesn't stand out enough. A grey “deprecated” tag (similar to tags in GitHub issues/PR) could help notice it more. Introducing such tags could also serve in the future to identify “official” chart types from those developed by 3rd parties.  **Chart examples thumbnails scrollbar** On Firefox DevEd 90.0b12 (64-bit), with ×150% zoom, some “non-scrollable scrollbars” appear around the chart example thumbnails area. In general, I would expect the thumbnails to be more flexible in their sizing (as it's not such an issue if they are downscaled, unlike the description text), so that they adapt to their container instead of forcing it to display scrollbars.  Related to this, the chart description and thumbnail area are 2 separate components, with independent scrollbars. It would feel more natural to me to consider both elements as one unique “scrollable” entity. (I.e. have only one scrollbar on the far right, even if it's the text that overflows.)  This would mean that “Example” become a sub-heading of the chart type (here “Heatmap”) — one could either introduce the “Description” subheading as well for the left column, or get rid of the “Example” one? --- All this being said, it's already such a huge step forward I'm very much looking forward to using in prod; thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
