michael-s-molina commented on a change in pull request #15799:
URL: https://github.com/apache/superset/pull/15799#discussion_r673266244
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -137,15 +143,16 @@ const Error = ({ error }: { error: string }) => (
const Select = ({
allowNewOptions = false,
ariaLabel,
+ fetchOnlyOnSearch,
Review comment:
> What do you think of changing this prop to `fetchOnFocus`? I think it
is more accurate as you are not typing anything but only focusing the input.
>
> Also, I remember agreeing that we should just set this as the standard as
it might be dangerous for performance otheriwse. What do you think?
I think you misunderstood the code. By default, the queries will only be
triggered when the select is opened for the first time. This is controlled by
the `loadingEnabled` state.
The `fetchOnlyOnSearch` property is another behavior where the queries will
only be triggered when there's a search input present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
