michael-s-molina commented on a change in pull request #15799:
URL: https://github.com/apache/superset/pull/15799#discussion_r673266812
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -361,13 +376,20 @@ const Select = ({
};
useEffect(() => {
- const foundOption = hasOption(searchedValue, selectOptions);
- if (isAsync && !foundOption) {
+ const allowFetch = !fetchOnlyOnSearch || searchedValue;
+ if (isAsync && loadingEnabled && allowFetch) {
Review comment:
Yes. Because no query should be fired before the user opens the select
for the first time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
