michael-s-molina commented on a change in pull request #15799:
URL: https://github.com/apache/superset/pull/15799#discussion_r673268734
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -361,13 +376,20 @@ const Select = ({
};
useEffect(() => {
- const foundOption = hasOption(searchedValue, selectOptions);
Review comment:
Yes. The problem with this check is that a search can result in more
than one page, which means that we can have results that were not fetched yet
and we should fire the request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
