kgabryje opened a new pull request #16444: URL: https://github.com/apache/superset/pull/16444
### SUMMARY We generate formData, which is passed through props to Chart, with a function `getFormDataWithExtraFilters`. The idea is to generate formData, save it in a cache object, and on each subsequent render use the cached version. However, due to incorrect equality checks, we never used the cached version and created a new formData object each time. That resulted not only in recalculating the same logic many times, but also triggered Chart's rerender, as formData object's reference was changing. Moreover, in Chart component's `shouldComponentUpdate` function we triggered rerender each time chart's visibility changed - in other words, we rerendered all charts every time we changed a tab. This PR fixes both of those behaviours. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No changes ### TESTING INSTRUCTIONS Everything should work as it did before. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC @junlincc @jinghua-qa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
