graceguo-supercat commented on a change in pull request #16444:
URL: https://github.com/apache/superset/pull/16444#discussion_r696353422
##########
File path: superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
##########
@@ -87,7 +87,8 @@ const defaultProps = {
// resizing across all slices on a dashboard on every update
const RESIZE_TIMEOUT = 350;
const SHOULD_UPDATE_ON_PROP_CHANGES = Object.keys(propTypes).filter(
- prop => prop !== 'width' && prop !== 'height',
+ prop =>
+ prop !== 'width' && prop !== 'height' && prop !== 'isComponentVisible',
Review comment:
Thanks for the work! this perf improvement work is great!
Before: chart component not update when width or height changed,
after: chart component not update width or height or visibility change.
But when chart component hide and show when tab changes, why chart component
not need update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
