kgabryje commented on a change in pull request #16444:
URL: https://github.com/apache/superset/pull/16444#discussion_r696388501
##########
File path: superset-frontend/src/dashboard/components/gridComponents/Chart.jsx
##########
@@ -100,6 +101,8 @@ const ChartOverlay = styled.div`
`;
export default class Chart extends React.Component {
+ static whyDidYouRender = true;
+
Review comment:
I left that in by accident, thanks for pointing out!
@graceguo-supercat In order to detect unnecessary rerenders, I use a library
`whyDidYouRender` (https://github.com/welldone-software/why-did-you-render).
Adding a static property `whyDidYouRender = true` to a component tells the
library to watch that component and report rerenders in the form of console
logs. Of course, I meant to cleanup those props, but clearly I missed that one
🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
