geido opened a new pull request #16510: URL: https://github.com/apache/superset/pull/16510
### SUMMARY The goal of this PR is to remove the SelectControl component entirely and refactor the selects using the Antdesign Select component. _Note: It appears that the SelectControl component was used also when not necessary. There are several instances where the search option is enabled for selects that clearly do not need the search. The reason is that the search option was enabled by default in the SelectControl. This PR does not aim to fix those behaviors. It replicates exactly the original options to reduce the impact. However, it will make sense to revisit the options that are used for each individual select in the future._ ### BEFORE/AFTER FILTER BOX https://user-images.githubusercontent.com/60598000/131366035-3ec160f0-a47b-481c-840a-a0d0f96ebc72.mp4 https://user-images.githubusercontent.com/60598000/131366101-b57626d5-791c-4c16-be88-23483bf8c0b7.mp4 ### BEFORE/AFTER SPATIAL CONTROL https://user-images.githubusercontent.com/60598000/131366899-94a6da97-503f-4a28-b277-1393a41e6164.mp4 https://user-images.githubusercontent.com/60598000/131367030-d96a2814-7e0f-44cc-b2ed-0ca786d57b11.mp4 ### BEFORE/AFTER ANNOTATION LAYERS https://user-images.githubusercontent.com/60598000/131367112-ba484ee5-4735-4bed-a0d6-1ebd9b6e2365.mp4 https://user-images.githubusercontent.com/60598000/131367165-bdde3baf-b1b7-4674-969e-fe61708ba1ee.mp4 ### BEFORE/AFTER DATASOURCE EDITOR https://user-images.githubusercontent.com/60598000/131367256-88fa9fdf-c3d4-441c-b43b-9a3330ca2c0b.mp4 https://user-images.githubusercontent.com/60598000/131367315-21ed3bb6-c95f-41b2-b847-1f1798985bb0.mp4 ### TESTING INSTRUCTIONS Test each component individually as shown in the videos ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
