geido commented on a change in pull request #16510:
URL: https://github.com/apache/superset/pull/16510#discussion_r699437443



##########
File path: superset-frontend/src/explore/components/controls/SelectControl.jsx
##########
@@ -18,22 +18,21 @@
  */
 import React from 'react';
 import PropTypes from 'prop-types';
-import { t, css } from '@superset-ui/core';
-import { Select, CreatableSelect, OnPasteSelect } from 'src/components/Select';
+import { css } from '@superset-ui/core';
+import { Select } from 'src/components';
 import ControlHeader from 'src/explore/components/ControlHeader';
 
 const propTypes = {
+  ariaLabel: PropTypes.string,

Review comment:
       All props here are cleaned and then mapped with the Select ones. This is 
to minimize impact as the SelectControl component is used dynamically 
throughout Superset and Superset-ui




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to