geido commented on a change in pull request #16510:
URL: https://github.com/apache/superset/pull/16510#discussion_r699335656
##########
File path:
superset-frontend/spec/javascripts/explore/components/SelectControl_spec.jsx
##########
@@ -48,58 +48,27 @@ describe('SelectControl', () => {
wrapper = shallow(<SelectControl {...defaultProps} />);
});
- it('uses Select in onPasteSelect when freeForm=false', () => {
- wrapper = shallow(<SelectControl {...defaultProps} multi />);
- const select = wrapper.find(OnPasteSelect);
- expect(select.props().selectWrap).toBe(Select);
- });
-
- it('uses Creatable in onPasteSelect when freeForm=true', () => {
- wrapper = shallow(<SelectControl {...defaultProps} multi freeForm />);
- const select = wrapper.find(OnPasteSelect);
- expect(select.props().selectWrap).toBe(CreatableSelect);
- });
-
it('calls props.onChange when select', () => {
const select = wrapper.instance();
- select.onChange({ value: 50 });
+ select.onChange(50);
expect(defaultProps.onChange.calledWith(50)).toBe(true);
});
- it('returns all options on select all', () => {
Review comment:
The "Select all" option has been removed as agreed with design and all
the related tests have been removed as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
