michael-s-molina commented on a change in pull request #16414:
URL: https://github.com/apache/superset/pull/16414#discussion_r699207898
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -194,6 +196,8 @@ export default class AddSliceContainer extends
React.PureComponent<
this.newLabel = this.newLabel.bind(this);
this.loadDatasources = this.loadDatasources.bind(this);
this.handleFilterOption = this.handleFilterOption.bind(this);
Review comment:
@villebro I don't have any objections as a temporary solution. We can
come back later and remove the client-side sorting. We'll probably need to do
that anyway with other selects.
Before merging, we need to also sort the values when the user opens the
select as stated here
https://github.com/apache/superset/pull/16414#discussion_r694734424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
