villebro commented on a change in pull request #16414:
URL: https://github.com/apache/superset/pull/16414#discussion_r696626626
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -194,6 +196,8 @@ export default class AddSliceContainer extends
React.PureComponent<
this.newLabel = this.newLabel.bind(this);
this.loadDatasources = this.loadDatasources.bind(this);
this.handleFilterOption = this.handleFilterOption.bind(this);
Review comment:
@etr2460 @ktmud do we agree that we want to paginate these requests, and
hence should also handle sorting in the backend? And if so, are we ok with
bumping exact matches to the top, or do we need to add some more exotic
ordering logic? If this is the case, I can prepare a small POC for the
`/related` endpoints to show how this could be done, after which we can
consider using the same pattern in all paginated select component requests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
