ktmud commented on a change in pull request #16414:
URL: https://github.com/apache/superset/pull/16414#discussion_r696063364
##########
File path: superset-frontend/src/addSlice/AddSliceContainer.tsx
##########
@@ -194,6 +196,8 @@ export default class AddSliceContainer extends
React.PureComponent<
this.newLabel = this.newLabel.bind(this);
this.loadDatasources = this.loadDatasources.bind(this);
this.handleFilterOption = this.handleFilterOption.bind(this);
Review comment:
`match-sorter`'s ranking algorithm is much more sophisticated than the
simple compare sorts the built-in API AntD Select can provide. For example,
`match-sorter` can filter by abbreviations---e.g. `abc_def_gh` can be matched
with `adg`---and each match thresholds can be assigned with different ranking
scores: exact match ranks before startsWith, startsWith ranks before
abbreviations, etc....
If reproducing the same logics become too cumbersome for the backend (I'd
imagine some of these have to be at the SQL level in order to be efficient), we
could just let the client side keep fetching next pages until there are enough
matched results to be displayed or reached the end of the list/maximum number
of items allowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
