AAfghahi edited a comment on pull request #17176: URL: https://github.com/apache/superset/pull/17176#issuecomment-952094308
@ktmud Hey! So I followed your advice and added a key to the AlertReportModal which really helped thank you for that! I ended up not doing the key to the TextAreaControl and instead put it on the entire modal. Regarding your point on the debouncer, doing some research I found that the react-ace editor has its own internal state for value and also has a built in debouncer, so I made the component into an uncontrolled component (though it still spreads props so the other places that use it will still be able to pass in value). This did require us to bump up react-ace because our current version had a known bug that finished. One thing to note is that this does drop bracejs as a dependency, but we have bracejs in our package.json so I don't think it will affect us in that way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
