AAfghahi commented on a change in pull request #17176:
URL: https://github.com/apache/superset/pull/17176#discussion_r737577020
##########
File path:
superset-frontend/src/SqlLab/components/TemplateParamsEditor/TemplateParamsEditor.test.tsx
##########
@@ -51,7 +51,7 @@ describe('TemplateParamsEditor', () => {
const spy = jest.spyOn(brace, 'acequire');
spy.mockReturnValue({ setCompleters: () => 'foo' });
await waitFor(() => {
- expect(baseElement.querySelector('#brace-editor')).toBeInTheDocument();
+ expect(baseElement.querySelector('#ace-editor')).toBeInTheDocument();
Review comment:
yes! Good catch, I just did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
