eschutho commented on a change in pull request #17176:
URL: https://github.com/apache/superset/pull/17176#discussion_r736999003
##########
File path: superset-frontend/src/explore/components/controls/TextAreaControl.jsx
##########
@@ -95,20 +76,21 @@ export default class TextAreaControl extends
React.Component {
style={style}
minLines={minLines}
maxLines={inModal ? 1000 : this.props.maxLines}
- onChange={this.onAceChangeDebounce}
+ onChange={this.props.onChange}
width="100%"
height={`${minLines}em`}
editorProps={{ $blockScrolling: true }}
- value={value}
+ defaultValue={this.props.defaultValue}
readOnly={this.props.readOnly}
+ key={this.props.name}
/>
);
}
return (
<TextArea
placeholder={t('textarea')}
onChange={this.onControlChange.bind(this)}
- value={value}
+ value={this.props.defaultValue}
Review comment:
this looks like it will never change value if you type in it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
