AAfghahi commented on a change in pull request #17176:
URL: https://github.com/apache/superset/pull/17176#discussion_r737591845
##########
File path: superset-frontend/src/views/CRUD/alert/AlertReportModal.tsx
##########
@@ -1136,7 +1138,8 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
maxLines={15}
onChange={onSQLChange}
readOnly={false}
- value={currentAlert ? currentAlert.sql : ''}
+ defaultValue={currentAlert?.sql}
+ key={currentAlert?.id || generateKey()}
Review comment:
yes, and I actually moved it over to the AlertReportModal because of
this. Earlier I had done this and the state issue had still persisted, but when
I test it now it is working fine. So I must have originally tested it during a
bad iteration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
