rusackas commented on issue #17359: URL: https://github.com/apache/superset/issues/17359#issuecomment-962108229
I think the truth here (and the difficulty of writing it up as a guideline) is finding a balance somewhere in the middle. I think the "break it up into files" approach is to (a) keep files from being so huge they're hard to maintain, and (b) keeping areas of functionality/intent/assertion orgainized in an approachable way. Nested describes do solve some useful concerns as Elizabeth states, however, in terms of organizing thoughts or assertions. I don't think there should be HUGE blocks, but it makes sense to organize things in a way such that if you break one test, you might want to think through the sibling/parent assertions/blocks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
