rusackas commented on issue #17359:
URL: https://github.com/apache/superset/issues/17359#issuecomment-962116333
Nesting also provides what I'd call an "inversion" problem... for example if
tests are structured like so:
- When user is logged in
- When button is clicked
- Expect X happens
- When a user is logged out
- When button is clicked
- Expect Y happens
When the outer "logged in" and "logged out" blocks get crazy long, a
developer might want to invert the structure to be something like:
- When button is clicked
- When user is logged in
- Expect X happens
- When a user is logged out
- Expect Y happens
If there were hundreds of tests, making that change would be painful. If
atomic tests were in folders/files, it might not be AS painful to restructure.
¯\\\_(ツ)_/¯
Really though, I think both patterns are fine, and it's ultimately a
question of having some sane threshold of _when_ to break it out by file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
