rusackas commented on issue #17359: URL: https://github.com/apache/superset/issues/17359#issuecomment-962211939
Continuing to ramble... just some notions of what we discussed in a chat. Both patterns (nesting describes, breaking out into discrete files) make a lot of sense. We should capture these in `DO` and `DON'T` statements... things like `DO` Use describe blocks to group small/reasonable sets of related tests, where editing one means you should probably revisit the others `DON'T` let nested describes get so long that it's difficult to navigate the hierarchy. If things get long, break them out into files! `DO` use separate files to organize and encapsulate tests of discrete areas/concerns `DON'T` get too "atomic" with excessively numerous test files to where it's difficult to find a test or maintain a set of tests `DON'T` use unnecessary abstractions - make sure it's possible for a new reader to easily understand the logic/process of a test. ... etc. You get the idea 😁 Thanks for bringing this conversation to light! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
