[GitHub] [superset] riahk commented on pull request #17372: feat: Add single select and inverse selection to numeric range (#16722)

[GitBox]

riahk commented on pull request #17372:
URL: https://github.com/apache/superset/pull/17372#issuecomment-977089335


   Code looks good, but the MIN slider UI is a bit misleading.
   <img width="249" alt="Screen Shot 2021-11-23 at 11 43 37 AM" 
src="https://user-images.githubusercontent.com/8216382/143093065-d276662e-c3d5-47fe-9f2c-936d14440258.png";>
   <img width="242" alt="Screen Shot 2021-11-23 at 11 43 43 AM" 
src="https://user-images.githubusercontent.com/8216382/143093082-ceaf41e2-5cfd-4570-b6cf-2c195f88ba7c.png";>
   
   I get that the `reverse` flag is meant to distinguish it from the MAX 
slider. I dug around through the antd docs and couldn't find a decent solution, 
though. I'm wondering if there's a way to style the MIN slider so the colors 
are inverted, here? That way the blue would appropriately distinguish the 
included range.
   Also — and this is probably excessive, since the user can name the filter 
whatever they want — maybe having an indicator next to the label of whether the 
slider is MIN/MAX/EXACT could be useful?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org