mhoustonataegis commented on pull request #17372: URL: https://github.com/apache/superset/pull/17372#issuecomment-982009429
> @mhoustonataegis @BillGreerUX These are excellent points! I like having the colors inverted for that distinction. > > What's confusing me still is that it's not clear to me which ends of the scale are high/low. With the `reverse` flag on the min slider, the colors invert, but so do the position of the high/low values! i.e. the "low" value is actually on the right, and the "high" is on the left, which can be confusing. > > My suggestion is to remove the `reverse` flag from the min slider, and then add the custom styling mentioned in my earlier comment to invert the colors. The effect is as follows: <img alt="Screen Shot 2021-11-29 at 12 39 38 PM" width="261" src="https://user-images.githubusercontent.com/8216382/143939786-4c5f76e5-0b91-48ba-a436-e91875d4d19a.png";> > > In this case, both sliders have the low value on the left, and the color inversion provides a distinction while still clearly indicating the inclusive range for the filter. Thoughts? Yes, my suggestion included removing the `reverse` flag, so that both min and max sliders used the same number lines for their values, but only different highlighting based upon your suggested css. So I think we're on the same page. I'll push up a new commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/8216382/143939786-4c5f76e5-0b91-48ba-a436-e91875d4d19a.png"](https://user-images.githubusercontent.com/8216382/143939786-4c5f76e5-0b91-48ba-a436-e91875d4d19a.png"){kind=link}