riahk commented on a change in pull request #17372:
URL: https://github.com/apache/superset/pull/17372#discussion_r759497811
##########
File path: superset-frontend/src/filters/components/Range/RangeFilterPlugin.tsx
##########
@@ -32,6 +32,39 @@ import { StatusMessage, StyledFormItem, FilterPluginStyle }
from '../common';
import { getRangeExtraFormData } from '../../utils';
import { SingleValueType } from './SingleValueType';
+const LIGHT_BLUE = '#99e7f0';
+const DARK_BLUE = '#6dd3e3';
+const LIGHT_GRAY = '#f5f5f5';
+const DARK_GRAY = '#e1e1e1';
+
+const StyledMinSlider = styled(Slider)<{
+ validateStatus?: 'error' | 'warning' | 'info';
+}>`
+ ${({ theme, validateStatus }) => `
+ .ant-slider-rail {
+ background-color: ${
+ validateStatus ? theme.colors[validateStatus]?.light1 : LIGHT_BLUE
+ };
+ }
+
+ .ant-slider-track {
+ background-color: ${LIGHT_GRAY} !important;
Review comment:
are we positive that this `!important` is needed, or are we just being
cautious?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
