lyndsiWilliams opened a new pull request #17573: URL: https://github.com/apache/superset/pull/17573
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Floating numbers were not sorting correctly in the result column. This was fixed by creating a `parseFloatingNums` function to parse any numbers in the result set. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> #### BEFORE <img width="167" alt="floatSortBefore" src="https://user-images.githubusercontent.com/55605634/143881005-4b5d7f2b-1de1-444f-a1ca-c9eac23370b6.png";> #### AFTER <img width="167" alt="floatSortAfter" src="https://user-images.githubusercontent.com/55605634/143881069-d0e9994b-da96-4539-882f-fef9bba166f0.png";> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> - Go to SQL Lab - Enter the following query using the superset example database: ``` SELECT status, year, sum(sales) FROM main.cleaned_sales_data GROUP BY status, year ``` - Click the sales column to sort - Observe that floating numbers are now sorting correctly ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/16971 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/55605634/143881005-4b5d7f2b-1de1-444f-a1ca-c9eac23370b6.png"](https://user-images.githubusercontent.com/55605634/143881005-4b5d7f2b-1de1-444f-a1ca-c9eac23370b6.png"){kind=link}
![https://user-images.githubusercontent.com/55605634/143881069-d0e9994b-da96-4539-882f-fef9bba166f0.png"](https://user-images.githubusercontent.com/55605634/143881069-d0e9994b-da96-4539-882f-fef9bba166f0.png"){kind=link}