lyndsiWilliams commented on a change in pull request #17573:
URL: https://github.com/apache/superset/pull/17573#discussion_r758689099
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -337,9 +342,9 @@ export default class FilterableTable extends PureComponent<
return -1;
}
if (descending) {
- return aValue < bValue ? 1 : -1;
+ return parseFloatingNums(aValue) < parseFloatingNums(bValue) ? 1 : -1;
Review comment:
Ah geez, it's not sorting strings correctly now. I thought that
`value.isNan ? value : parseFloat(value)` would process strings properly since
it checks if the value isn't a number and returns it unparsed if it's not. Good
catch, thanks! I'll look further into this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
