lyndsiWilliams commented on a change in pull request #17573:
URL: https://github.com/apache/superset/pull/17573#discussion_r759681711
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -337,9 +342,9 @@ export default class FilterableTable extends PureComponent<
return -1;
}
if (descending) {
- return aValue < bValue ? 1 : -1;
+ return parseFloatingNums(aValue) < parseFloatingNums(bValue) ? 1 : -1;
Review comment:
Thank you for the tips! As discussed in our 1:1, I've got the sort now
working with strings _and_ numbers. I also got it to work with localeCompare,
it's looking cleaner and now it works multilingually! All done in [`this
commit`](https://github.com/apache/superset/pull/17573/commits/43742de0d792866aa22734ee41a4e82bbcb20643)
😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
